Skip to content

konflux build: add openblas-thread lib for numpy wheel #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
raptorsun wants to merge 1 commit into
base: main
Choose a base branch
from
Open

konflux build: add openblas-thread lib for numpy wheel #1066

raptorsun wants to merge 1 commit into from

Conversation

@raptorsun
Copy link
Contributor

@raptorsun raptorsun commented Jan 27, 2026 •
edited by coderabbitai bot
Loading

Description

fix missing lib problem for numpy wheel from RHOAI

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement

Tools used to create PR

Identify any AI code assistants used in this PR (for transparency and review context)

  • Assisted-by: (e.g., Claude, CodeRabbit, Ollama, etc., N/A if not used)
  • Generated by: (e.g., tool name and version; N/A if not used)

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Summary by CodeRabbit

  • Chores
    • Updated system dependencies and kernel packages across supported architectures.
    • Added OpenBLAS threading support to improve numerical computation performance.
    • Created application cache and storage directories with corrected ownership to ensure proper runtime access.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 27, 2026 •
edited
Loading

Walkthrough

Final image package list and RPM lockfile updated: openblas-threads added; new runtime directories (/opt/app-root/src/.llama, .../storage/providers.d, and /opt/app-root/src/.cache) created with ownership set to UID:GID 1001:1001; rpms.lock.yaml expanded with many package entries and kernel-headers version bump.

Changes

Cohort / File(s) Summary
Containerfile
Containerfile		 Adds openblas-threads to final-image package install; creates directories /opt/app-root/src/.llama, /opt/app-root/src/.llama/storage/providers.d, and /opt/app-root/src/.cache and applies chown 1001:1001 to them.
RPM inputs
rpms.in.yaml		 Adds openblas-threads to the declared package list.
RPM lock / registry
rpms.lock.yaml		 Large lockfile update: kernel-headers EVR bumped (611.24.1 → 611.26.1) and many new/updated package entries across aarch64 and x86_64 for streams (baseos, appstream, codeready-builder), including openblas, openblas-threads, openssl, systemd family, pam, util-linux, libgfortran, and related libs with updated URLs, sizes, and checksums.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested reviewers

  • radofuchs
  • tisnik
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'konflux build: add openblas-thread lib for numpy wheel' directly reflects the main changes in the PR, which add the openblas-threads package to the Konflux build configuration across multiple files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot reviewed Jan 27, 2026
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents 
In `@Containerfile`:
- Around line 95-98: Remove the temporary NumPy verification RUN block that
echoes and runs python3.12 -c "import numpy..." from the Containerfile; if you
must keep a temporary check during debugging, replace the direct python3.12
invocation with the venv-bound interpreter /app-root/.venv/bin/python3.12 to
avoid bypassing the virtualenv, but for merge delete the entire verification
lines and the TODO comment to avoid extra build overhead and potential release
failures.

Containerfile Outdated
Comment on lines 95 to 98
# todo :remove this after testing
RUN echo "Verifying numpy installation..." && \
python3.12 -c "import numpy; print('numpy version:', numpy.__version__)" && \
echo "numpy verification successful"
Copy link
Contributor

@coderabbitai coderabbitai bot Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

# First, locate the Containerfile
fd -type f -name "Containerfile" -o -name "Dockerfile"

Repository: lightspeed-core/lightspeed-stack

Length of output: 246

🏁 Script executed:

# Read the Containerfile to check lines 95-98
head -100 Containerfile | tail -10

Repository: lightspeed-core/lightspeed-stack

Length of output: 386

🏁 Script executed:

# Get more context around lines 95-98
sed -n '80,110p' Containerfile

Repository: lightspeed-core/lightspeed-stack

Length of output: 1493

🏁 Script executed:

# Check if there are any build ARGs that could gate this
rg "ARG|COPY|FROM" Containerfile | head -20

Repository: lightspeed-core/lightspeed-stack

Length of output: 555

Remove the temporary NumPy verification step before merge.

The TODO comment at Line 95 indicates this is temporary code. This verification layer should be removed before shipping to avoid unnecessary build overhead and prevent release build failures if the import breaks. The code uses python3.12 directly, which bypasses the venv in PATH; if you retain it temporarily, use /app-root/.venv/bin/python3.12 to target the installed wheel. Lines 95-98.

🧹 Suggested removal 
-# todo :remove this after testing
-RUN echo "Verifying numpy installation..." && \
-    python3.12 -c "import numpy; print('numpy version:', numpy.__version__)" && \
-    echo "numpy verification successful"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# todo :remove this after testing
RUN echo "Verifying numpy installation..." && \
python3.12 -c "import numpy; print('numpy version:', numpy.__version__)" && \
echo "numpy verification successful"
🤖 Prompt for AI Agents 
In `@Containerfile` around lines 95 - 98, Remove the temporary NumPy verification
RUN block that echoes and runs python3.12 -c "import numpy..." from the
Containerfile; if you must keep a temporary check during debugging, replace the
direct python3.12 invocation with the venv-bound interpreter
/app-root/.venv/bin/python3.12 to avoid bypassing the virtualenv, but for merge
delete the entire verification lines and the TODO comment to avoid extra build
overhead and potential release failures.

@raptorsun
konflux build: add openblas-thread lib for numpy wheel
c1e0a39 
Signed-off-by: Haoyu Sun <hasun@redhat.com>
@raptorsun raptorsun changed the title [WIP] konflux build: add openblas-thread lib for numpy wheel konflux build: add openblas-thread lib for numpy wheel Jan 27, 2026
@raptorsun
Copy link
Contributor Author

raptorsun commented Jan 27, 2026

ready to review and merge :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@raptorsun